Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported code refactor #94

Merged
merged 89 commits into from
Dec 14, 2019
Merged

Ported code refactor #94

merged 89 commits into from
Dec 14, 2019

Conversation

sertansenturk
Copy link
Owner

No description provided.

@sertansenturk
Removed duplicate method symbtr.extras.txt.TxT.to_musicxml
8b8473e 
Better method exists in scoreconverter
@sertansenturk
Moved all methods in extras/score.py to extras/txt.py
42886d8
@sertansenturk
Moved tomato/symbolic/symbtr/metadata to tomato/metadata/symbtr/
482f062
@sertansenturk
Fixed several PEP8 violations
8be0618
@sertansenturk
tomato.metadata.work._add_scores calls the more general _read_symbtr_…
2219689 
…mbid_dict
@sertansenturk
Refactored class variable names in tomato/metadata/symbtr/musicbrainz
5971b30
@sertansenturk
Instantiated tomato/symbolic/symbtr/converter/ package
8c343b7
@sertansenturk
Moved tomato/symbolic/musicxmlconverter and tomato/symbolic/musicxml2…
46c8eaa 
…lilypond to tomato/symbolic/symbtr/converter/musicxml2lilypond
@sertansenturk
Renamed musicxmlconverter to symbtr2musicxml
83b2430
@sertansenturk
Moved tomato/symbolic/symbtr/converter/ to tomato/symbolic/converter/
6ec7f95
@sertansenturk
Renamed tomato/symbolic/scoreconverter.py -> tomato/symbolic/symbtrco…
cb88eeb 
…nverter.py
@sertansenturk
Switched all absolute imports within the package to relative
af3ffc8
@sertansenturk
Updated score_analysis_demo.ipynb
41e9c4e
@sertansenturk
Renamed erroneously changed symbtr variable back to metadata
b7cf0c8
@sertansenturk
Fixed a minor PEP8 violation in audioanalyzer
dd27519
@sertansenturk
Refactored duplicate pickle I/O methods in pitchdistribution
107b65d
@sertansenturk
Removed unused pickle import from tomato/audio/pitchdistribution.py
b1bbaa2
@sertansenturk
Converted get_attr_key_from_mb_attr and _get_attr_key_from_mb_tag in …
23dce0a 
…metadat.attribute to staticmethods
@sertansenturk
tomato connects to musicbrainzngs with its name
3d2d80a
@sertansenturk
Made several method names more clear
a344b94
@sertansenturk
Changed MusicBrainzMetadata class name to MusicBrainz
7a9a7b1
@sertansenturk
Changed absolute imports to relative
71549dc
@sertansenturk
Removed get_work_attributes input from Recording constructor
415eaab
@sertansenturk
Removed Recording constructor
7ad7487
@sertansenturk
Recording class is not alled directly in audio_analysis
a52fe03
@sertansenturk
The analysis classes have their of own logging:
f9fdf77
@sertansenturk
Fixed minor PEP8 error
b1bcdf8
@sertansenturk
Fixed additional PEP8 violaitons
f1f8c4f
@sertansenturk
Ordered the imports
7d73906
@sertansenturk
metadata.symbtr.musicbrainz makes a direct call to metadata.Recording…
a33df14 
… instead of instantiation
@sertansenturk sertansenturk changed the base branch from master to dev November 19, 2019 00:38
@codecov
Copy link

codecov bot commented Dec 14, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@ae930b9). Click here to learn what that means.
The diff coverage is 2.12%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev     #94   +/-   ##
=====================================
  Coverage       ?   0.39%           
=====================================
  Files          ?      46           
  Lines          ?    5313           
  Branches       ?       0           
=====================================
  Hits           ?      21           
  Misses         ?    5292           
  Partials       ?       0
Impacted Files Coverage Δ
tomato/symbolic/symbtr/reader/txt.py 0% <ø> (ø)
tomato/symbolic/symbtr/rhythmicfeature.py 0% <ø> (ø)
tomato/symbolic/symbtr/scoreprocessor.py 0% <ø> (ø)
...lic/symbtr/converter/symbtr2musicxml/symbtrnote.py 0% <ø> (ø)
tomato/audio/makamtonic/knn.py 0% <ø> (ø)
tomato/joint/completeanalyzer.py 0% <0%> (ø)
tomato/symbolic/symbtranalyzer.py 0% <0%> (ø)
tomato/audio/makamtonic/toniclastnote.py 0% <0%> (ø)
tomato/audio/ahenk.py 0% <0%> (ø)
tomato/audio/predominantmelody.py 0% <0%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae930b9...b16ac95. Read the comment docs.

@sertansenturk sertansenturk merged commit 158913a into dev Dec 14, 2019
@sertansenturk sertansenturk deleted the ported_code_refactor branch December 14, 2019 23:57
This was referenced Dec 15, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sertansenturk