Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Meteor 3 #92

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

StorytellerCZ
Copy link
Contributor

Following #91, this is an attempt to quickly update the main package for Meteor 3.

Following serut#91, this is an attempt to quickly update the main package for Meteor 3.
@jankapunkt
Copy link
Collaborator

@serut can you please take a look at this? It's really important, because otherwise people can't upgrade to Meteor 3

@serut
Copy link
Owner

serut commented Jul 17, 2024

Ok, but it means the package may not work at all on Meteor 3. Publishing a not working version is not great, did you tryed to run tests ? The test creates a Meteor app and add the local package inside the build so you can test if it works.

Sadly, the CI (travis..) is not working anymore..

@jankapunkt
Copy link
Collaborator

@serut I can easily add GitHub ci if you want

@serut
Copy link
Owner

serut commented Jul 17, 2024

Feel free yes

@jankapunkt
Copy link
Collaborator

@serut see #93

@jankapunkt
Copy link
Collaborator

@StorytellerCZ if testing locally the setup command should be changed to

    "setup-test": "rm -rf ./someapp && meteor create --release 3.0.1 --bare someapp && cd someapp && cp ../.coverage.json . && meteor npm i --save puppeteer && mkdir packages && ln -s ../../ ./packages/meteor-coverage",

@serut
Copy link
Owner

serut commented Jul 17, 2024

Now there is CI on every MR, can you try to fix tests jankapunkt ?
I can give write access to this repository if you want to.

@jankapunkt
Copy link
Collaborator

hi @serut yes, isn't that what you want - have a mr being checked if it passes lint and tests? I can modify but I would have to know what you intend it to work. Wrie access would be great as I already found a few more things to be updated for Meteor 3 (Webapp, HTTP package etc.)

@serut
Copy link
Owner

serut commented Jul 18, 2024

Oh sorry, I was wondering if you could check why the build is not working. It's nice to have github actions but better to have tests running well .. It tells npm ci cannot be run without npm-shrinkwrap.json file...

see https://github.com/serut/meteor-coverage/actions/runs/9980609619/job/27582397140

@jankapunkt
Copy link
Collaborator

@serut can you please re-invite me? I was on vacation and the link expired. I can look into the action logs as member. Usually this is just a missing package-lock.json or deleting and reinstalling npm deps. Should not be hard to fix. After that I can work on 3.0 compat.

@jankapunkt jankapunkt changed the base branch from master to migration/3.0 August 1, 2024 06:03
@jankapunkt jankapunkt merged commit 8133c2f into serut:migration/3.0 Aug 1, 2024
1 check passed
@StorytellerCZ StorytellerCZ deleted the patch-2 branch August 1, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants