Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverless logs not logging the correct version after serverless deploy function #89

Closed
rklhui opened this issue Jan 4, 2018 · 3 comments

Comments

@rklhui
Copy link

rklhui commented Jan 4, 2018

The alias of cloudformation stack file is not updated to the latest version after serverless deploy function with alias, leading to serverless logs with alias still displaying the old version of the alias. I guessed either having the --version=latest or --version=xx on serverless logs could solve the problem without updating the cloudformation stack (as this is kind of counter-intuitive).

@HyperBrain
Copy link
Member

Hi @rklhui , good catch. However, I would prefer the "version" variant, as latest is a floating label, that can easily be wrong as soon as someone else deploys his alias.

@rklhui
Copy link
Author

rklhui commented Jan 5, 2018

Hey @HyperBrain, please see if this helps.
#90

@HyperBrain
Copy link
Member

@rklhui Thanks 😄 . I already added a few comments to the PR and will test it this weekend.

@HyperBrain HyperBrain added this to the 1.6.0 milestone Jan 24, 2018
@HyperBrain HyperBrain modified the milestones: 1.6.0, 1.7.0 Mar 7, 2018
HyperBrain added a commit that referenced this issue Mar 7, 2018
Enhance alias logs function #89 #62
defnotrobbie pushed a commit to 1stdibs/serverless-aws-alias that referenced this issue Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants