Supporting dash in alias name when creating api gateway authorizers #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HyperBrain I appreciate it if you could take a look at this. It's been sitting here for a month and a half. I need this published. Thanks. |
ziadloo
changed the title
aniva
approved these changes
Jun 11, 2019
Enase
approved these changes
Jun 12, 2019
|
Hi, thanks for approving it, when it will be published to npm? |
|
coming soon.. today, I hope.. |
|
Thanks a lot and have a great day!
…On Thu, Jun 13, 2019 at 5:46 AM Sergii Kovalev ***@***.***> wrote:
coming soon.. today, I hope..
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#149?email_source=notifications&email_token=ACHTVNMUR5MC5T6PCSCKF23P2IJORA5CNFSM4GKALA62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTEW3Q#issuecomment-501631854>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACHTVNOE7OG7KPTUAEAKYQ3P2IJORANCNFSM4GKALA6Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the
-in the alias for the API Gateway template name. Without this change, chosing an alias name with-in it while your definition has an API Gateway with authorizers in it will fail.