Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix authorizer Uri #54

Merged
merged 1 commit into from
Jun 6, 2017
Merged

fix authorizer Uri #54

merged 1 commit into from
Jun 6, 2017

Conversation

vkkis93
Copy link
Contributor

@vkkis93 vkkis93 commented Jun 6, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.678% when pulling 953775f on vkkis93:master into c2d4dba on HyperBrain:master.

@HyperBrain HyperBrain added this to the 1.2.1 milestone Jun 6, 2017
@HyperBrain
Copy link
Member

Nice work 👍 . Just verified that the deployed authorizer calls the correct function alias. (I changed the alias example project to contain an authorizer test branch that can be used to verify authorizer functionality).
The only thing I found is, that the "test your authorizer" functionality in the console does not work with the stage variable. But I think that's ok, as the lambda function name is editable - I'm sure that is the same behavior as for Serverless 0.5.
PR approved. I'll merge it.

@vkkis93
Copy link
Contributor Author

vkkis93 commented Jun 6, 2017

@HyperBrain you absolutely right

@HyperBrain HyperBrain merged commit c27ce05 into serverless-heaven:master Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@vkkis93 @coveralls @HyperBrain