Fix user error reporting #1005
Merged
Fix user error reporting #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
force-pushed
the
1119-improve-error-reporting
branch
from
ee3be9f to
14a7f12
Compare
|
Does |
Yes, it's there since v1.0.0: https://github.com/serverless/serverless/blob/v1.0.0/lib/Serverless.js#L42 |
j0k3r
approved these changes
Nov 19, 2021
vicary
approved these changes
Nov 19, 2021
|
@medikoo One more rebase :) |
medikoo
force-pushed
the
1119-improve-error-reporting
branch
from
14a7f12 to
a542ec4
Compare
|
@j0k3r rebased :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Serverless Framework all user errors are expected to be reported with
ServerlessErrorinstance (class accessible atthis.serverless.classes.Error) otherwise error is assumed as programmatic, and when thrown, whole stack trace is presented.This patch ensures that those common user errors are reported with
ServerlessError