Modern logs for Serverless Framework v3

[medikoo]

Configure modern logs with provided new logging interface, maintaining compatibility with v2 release of a Framework (this PR ensures no changes to log output happens for that version).

New logs can be tested with serverless@pre-3 release

After v3 is released, we may consider dropping support for v2, and cleaning up the code so only modern logs are configured - I can help providing a PR

v2 Logs (before)

success:

warning:

error:

v3 Logs (after)

progress:

success:

warning:

error:

[j0k3r]

Could you also add build specific to Serverless v3? Like the one we have for Serverless v1?

[medikoo]

Could you also add build specific to Serverless v3? Like the one we have for Serverless v1?

@j0k3r I'm not sure exactly to what build you're referring. Can you provide more details?

[j0k3r]

I'm not sure exactly to what build you're referring. Can you provide more details?

We have a dedicated build for Serverless v1 (other build use the v2).

serverless-webpack/.github/workflows/tests.yml

Lines 70 to 99 in 2776bcf

	serverless-v1:
	runs-on: ${{ matrix.os }}
	name: Node.js ${{ matrix.node }} on ${{ matrix.os }} with Serverless v1
	strategy:
	matrix:
	os:
	- ubuntu-20.04
	node:
	- "14"
	steps:
	- name: "Checkout"
	uses: actions/checkout@v2
	with:
	fetch-depth: 2
	- name: "Install Node.js"
	uses: actions/setup-node@v2
	with:
	node-version: "${{ matrix.node }}"
	- name: "Install Serverless v1"
	run: npm install serverless@1
	- name: "Install dependencies"
	run: npm ci
	- name: "Run tests"
	run: "npm run test"

Adding that kind of stuff for Serverless v3, maybe it could interesting to have a build dedicated to that version too.

[medikoo]

We have a dedicated build for Serverless v1 (other build use the v2).

Currently, we have just pre-release of v3, but I agree it's good to add it to testing. I've setup dedicated job

[j0k3r]

The build using Serverless pre-release is failing. Do you think it's too soon to include it?
If there are more work to be done on serverless-webpack for the v3 compatibility, maybe we can postpone that build for later, what do you think?

There is one last change to apply #1013 (comment) and we'll be good to go

[medikoo]

The build using Serverless pre-release is failing. Do you think it's too soon to include it?

Great thanks for pointing I've missed that.

I've fixed it, it was a question of providing some data which in v3 is required by Serverless constructor (and passing it to older version is safe). So it's good to have addressed

[j0k3r]

Great, just rebase against the master and it'll be good!

[medikoo]

Sure, rebased, thank you!

[j0k3r]

Thanks for all the work 🤝

[j0k3r]

Oh sh*t. We won't be able to merge because of the coverage drops 🤦‍♂️
I'll ask to remove the required on it.

[mnapoli]

@j0k3r FYI we are closing in on the v3 stable release. Not sure how we could help to move this forward, let us know

[mnapoli]

Quick update: v3 release is next week

[j0k3r]

Thanks @mnapoli.
As I said to @medikoo, we are stuck until a reply from @HyperBrain to unlock PRs. Sorry.

[j0k3r]

Hello @medikoo sorry for being late, the coveralls check is no more required.
Can you rebase and fix conflicts and we'll (finally) be able to merge your work!

[medikoo]

@j0k3r updated!

[j0k3r]

Finally 🥳