Add the --skip-build CLI option
#1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicary
reviewed
Jul 5, 2022
j0k3r
force-pushed
the
feature/re-add-no-build-cli-option
branch
from
6e24bc5
to
e148d35
Compare
j0k3r
changed the title
--no-build CLI option --skip-build CLI option
|
Because of Serverless automatically handling |
vicary
reviewed
Jul 13, 2022
We removed it because it was generating some deprecated message and we introduced the parameter `noBuild` instead. Now the CLI option is back as a new name (see below) and the parameter is kept. Serverless add an extra CLI option prefixed with `--no-` in case we add a new CLI option (ie: `--build`). But we don't need the `--build` option, only the `--no-build` which isn't possible. So we renamed it to `--skip-build`
j0k3r
force-pushed
the
feature/re-add-no-build-cli-option
branch
from
8128a4d
to
2132777
Compare
vicary
approved these changes
Jul 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed it because it was generating some deprecated message and we introduced the parameter
noBuildinstead.Now the CLI option is back and the parameter is kept.
Kind of revert #1007
Double fix #965
The first commit is from #1187, it'll be dropped once the PR is merged and that one is rebased.