Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Upgrade deps #227

Merged
merged 3 commits into from
Sep 18, 2017
Merged

- Upgrade deps #227

merged 3 commits into from
Sep 18, 2017

Conversation

franciscocpg
Copy link
Member

@franciscocpg franciscocpg commented Sep 18, 2017 •
edited
Loading

  • Improve webpack.config to import ts files without adding extension

What did you implement:

Closes #214

How did you implement it:

Adding webpack default resolve extensions plus ts files extension (.ts, .tsx).

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@franciscocpg
- Upgrade deps
98849d3 
- Improve webpack.config to import ts files without adding extension
@franciscocpg
Using default extensions plus ts extensions
3f76e51
@franciscocpg
Using webpack v3 defaults
e83385b
@franciscocpg franciscocpg mentioned this pull request Sep 18, 2017
Closed
@HyperBrain HyperBrain merged commit 39b9628 into serverless-heaven:master Sep 18, 2017
@franciscocpg franciscocpg deleted the update-typescript-example branch September 18, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyperBrain HyperBrain HyperBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to import local files
2 participants
@franciscocpg @HyperBrain