Update README.md to fix sample config. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path needs to be an absolute path since webpack 2.3.1, sample code will not run. `- configuration.output.path: The provided value ".webpack/service" is not an absolute path!`
HyperBrain
requested changes
Oct 30, 2017
There was a problem hiding this comment.
Hi @thepont , great find 🙌 and thank you for the PR.
Could you add the filename change too?
README.md
Outdated
|
|
||
| module.exports = { | ||
| // ... | ||
| output: { | ||
| libraryTarget: 'commonjs', | ||
| path: '.webpack', | ||
| path: path.resolve(__dirname, '.webpack'), | ||
| filename: 'handler.js', // this should match the first part of function handler in `serverless.yml` |
There was a problem hiding this comment.
Since 3.x.x the filename should also be defined as [name].js so that it can be used with automatic entry resolution, which is now the preferred way to set the entries.
There was a problem hiding this comment.
Changed it right now - ready to merge 😄
HyperBrain
approved these changes
Oct 31, 2017
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
Update README.md to fix sample config.
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
Update serverless-heaven#265 Added serverless-heaven#260 Added release notes. Increased version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path needs to be an absolute path since webpack 2.3.1 current sample code in documentation will not run.
- configuration.output.path: The provided value ".webpack/service" is not an absolute path!What did you implement:
Fix for a sample in the documentation, webpack requires
pathto be absolute.Closes #XXXXX
How did you implement it:
Starting with the sample code, I adjusted it so it worked. using path.resolve to resolve the abs path for web pack.
How can we verify it:
Check that sample correctly runs by running the webpack.config.js
Todos:
Is this ready for review?: Yes
Is it a breaking change?: NO