Add warning about auto-packing when using yarn #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpiatek 👍 That should be good to let people know about the issue upfront. |
|
BTW: |
HyperBrain
reviewed
Feb 6, 2018
README.md
Outdated
| @@ -210,6 +210,12 @@ custom: | |||
| ``` | |||
| > Note that only relative path is supported at the moment. | |||
|
|
|||
| #### Usage with yarn | |||
|
|
|||
| Note that if auto-packing is enabled, the plugin will call `npm install`. If you are using yarn your `yarn.lock` file will be not be honored, which might lead to unexpected results as your dependencies will most likely not match (or be missing, as npm does not install packages in the same as npm). | |||
There was a problem hiding this comment.
Shouldn't this be [...] install packages in the same *way as yarn*?
There was a problem hiding this comment.
Can't believe I did not see that, fixed!
dpiatek
force-pushed
the
add-yarn-readme-note
branch
from
2990b51
to
9cfad1e
Compare
dpiatek
force-pushed
the
add-yarn-readme-note
branch
from
9cfad1e
to
292d595
Compare
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
…-note Add warning about auto-packing when using yarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #316
How did you implement it:
Docs update.
How can we verify it:
Check statements and spelling 👨🏫
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO