Abstract packager into universal interface. #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unit tests have to be adapted and new ones have to be added for the packagers. |
Extended pack external unit tests Added unit tests for npm packager Adapted unit tests Exclude test.js files from nyc statistics Added unit test for packager factory Extract optional lock file adaption Fixed ESLint ESLint fixes Moved npm to a separate packager class.
HyperBrain
force-pushed
the
329-packager-interface
branch
from
0db36a3 to
fee4947
Compare
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
…ackager-interface Abstract packager into universal interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #329
This PR opens the way to add other packagers (than npm) to serverless-webpack. It is a prerequisite for #286 which proposes the alternative use of Yarn.
How did you implement it:
Added a packager factory (
./lib/packagers/index) and ported npm functionality to the new interface.Serverless-webpack will now try to create the wanted packager with the factory.
Additionally started transition of unit tests adjacent to their code under test. That makes it clear what is correctly tested and what not.
How can we verify it:
Everything should still work as before :)
Todos:
Is this ready for review?: NO
Is it a breaking change?: NO