Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #337

Merged
merged 2 commits into from
Mar 7, 2018
Merged

Unit tests #337

merged 2 commits into from
Mar 7, 2018

Conversation

HyperBrain
Copy link
Member

@HyperBrain HyperBrain commented Mar 7, 2018

What did you implement:

Add complete unit test for index.js

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@HyperBrain HyperBrain added this to the 5.0.0 milestone Mar 7, 2018
@HyperBrain HyperBrain merged commit 88a7017 into v5 Mar 7, 2018
@HyperBrain HyperBrain deleted the unit-tests branch March 7, 2018 15:44
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant