Added error if needed runtime dependency is a devDependency #384
+215
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released with 5.1.5 |
This was referenced Sep 23, 2018
1 task
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
…vement/better-missing-dep-errors Added error if needed runtime dependency is a devDependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Relates to #383, #369 (comment), #230
This PR introduces better error handling for the case that a runtime dependency detected by Webpack is only found in
devDependenciesand would lead to anUnable to import moduleerror when deployed.If the detected module is forcefully excluded it will, however, succeed.
How did you implement it:
Added a check for devDependencies in the production module loop.
How can we verify it:
Move a needed dependency to devDependencies. It should error out as long as the dependency is not forcefully excluded.
Todos:
Write documentationIs this ready for review?: YES
Is it a breaking change?: NO