Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to keep the output directory #469

Merged
merged 3 commits into from
Apr 7, 2019

Conversation

jaydp17
Copy link
Contributor

@jaydp17 jaydp17 commented Jan 4, 2019

What did you implement:

Closes #453
Closes #467

How did you implement it:

There's an option we can pass keepOutputDirectory, which will skip the cleanup process.

# serverless.yml
custom:
  webpack:
    keepOutputDirectory: true

How can we verify it:

  1. As described above, just add the flag in serverless.yml.
  2. Run sls package
  3. Verify that .webpack is present

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@abbottry
Copy link

abbottry commented Feb 13, 2019

This would be extremely helpful. I'm unsure why this plugin takes this action -- it prevents serverless-s3-sync from working properly as when it attempts to sync, the directory is gone.

@colkito
Copy link

colkito commented Mar 18, 2019

any scheduled date for merge this PR?

@jaydp17
Copy link
Contributor Author

jaydp17 commented Mar 18, 2019

@colcodev, I'm not sure about it.
May be @HyperBrain is super busy, but then again it's been over 3 months since the PR opened.
Anyways, I have been using the fork, so if you need this immediately, that could be one of the options.

@HyperBrain HyperBrain added this to the 5.3.0 milestone Apr 7, 2019
@HyperBrain
Copy link
Member

@jaydp17 I indeed was super busy the last few months. Sorry for that. The feature looks ok to me and should be part of 5.3.0 as it is a new feature.

Copy link
Member

@HyperBrain HyperBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HyperBrain HyperBrain merged commit b094a9e into serverless-heaven:master Apr 7, 2019
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to keep the .webpack folder after bundling Add support to keep output directory after package/deploy
4 participants