Fix eslint prettier

[asprouse]

What did you implement:

Closes #515

How did you implement it:

• Configure prettier-eslint to format code, remove eslint-config-prettier
• Update prettier config to be closer to existing code
• Move npm test command out of lint-staged to .huskyrc. This was causing errors trying to run staged files as if they were tests. All tests should be run not just the staged test files.
• Reformat code with prettier-eslint

How can we verify it:

• @HyperBrain Look at the last commit in this PR and make sure that the code style is acceptable since introducing prettier normalizes spacing, semicolons, line-length, etc. I tried to make the config as close to the current style preferences but the current ESLint rules weren't tight enough to enforce consistency code being reformatted was inevitable.
• run npm run format then npm run eslint and verify there are no formatting lint issues
• Try committing some code then run npm run eslint and ensure there are no issues.

Todos:

• Write tests
• Write documentation
• Fix linting errors
• Make sure code coverage hasn't dropped (Some existing lines were split that contained uncovered code this increased the number of uncovered lines but didn't affect branches or functions).
• Provide verification config / commands / resources
• Enable "Allow edits from maintainers" for this PR
• Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

[HyperBrain]

Looks good to me. Now it should be much easier again to contribute without anyone being annoyed by uncontrollable changes.

[asprouse]

Great! Merge away!

[HyperBrain]

Will do it this evening.

…

On Sun, Jun 16, 2019 at 6:50 PM Andrew Sprouse ***@***.***> wrote: Great! Merge away! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#518?email_source=notifications&email_token=ABKEZXX5TTCPRFRVJPVAQB3P2ZVMHA5CNFSM4HYPPENKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZQ3AQ#issuecomment-502467970>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKEZXXOWMVG5YWBXUA4E5TP2ZVMHANCNFSM4HYPPENA> .

[HyperBrain]

Merged. Feel free to get the other PR to fit now ;-)