Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create npmpublish.yml GitHub Action #581

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Create npmpublish.yml GitHub Action #581

merged 3 commits into from
Apr 26, 2020

Conversation

miguel-a-calles-mba
Copy link
Member

@miguel-a-calles-mba miguel-a-calles-mba commented Apr 20, 2020

What did you implement:

Closes #XXXXX

Adding a GitHub Action to automatically publish to npm.

How did you implement it:

Added a GitHub Action YAML workflow.

How can we verify it:

Define the NPM_TOKEN secret in the settings. Update the package version, create a release, and see the action work. https://github.com/serverless-heaven/serverless-webpack/actions

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@miguel-a-calles-mba
Copy link
Member Author

miguel-a-calles-mba commented Apr 20, 2020

@HyperBrain Are you comfortable creating an npm token and adding it to the "secrets" in this repository's settings? This way, we can automatically publish to npm when we create a GitHub release.

The secrets are not visible by anyone, not even the person who created it.

@revgum
Copy link

revgum commented Apr 21, 2020

Thank you @HyperBrain and @miguel-a-calles-mba for keeping traction on this repo, it's very handy and still quite active!

I'm eagerly awaiting PR #570 as I'm sure there are several others as well.

@miguel-a-calles-mba
Copy link
Member Author

@revgum np.

I'm looking forward to other PRs too. =)

@HyperBrain
Copy link
Member

HyperBrain commented Apr 22, 2020 via email

@miguel-a-calles-mba
Copy link
Member Author

Thanks @HyperBrain !

@miguel-a-calles-mba
Copy link
Member Author

@HyperBrain @jamesmbourne @rdsedmundo Reference the internal team discussion about the updated npm token secret.

@miguel-a-calles-mba miguel-a-calles-mba added this to the 5.3.2 milestone Apr 24, 2020
@miguel-a-calles-mba miguel-a-calles-mba self-assigned this Apr 24, 2020
@miguel-a-calles-mba miguel-a-calles-mba changed the title Create npmpublish.yml Create npmpublish.yml GitHub Action Apr 26, 2020
@miguel-a-calles-mba miguel-a-calles-mba merged commit ada12f9 into master Apr 26, 2020
@miguel-a-calles-mba miguel-a-calles-mba deleted the npmpublish branch April 26, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants