-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create npmpublish.yml GitHub Action #581
Conversation
@HyperBrain Are you comfortable creating an npm token and adding it to the "secrets" in this repository's settings? This way, we can automatically publish to npm when we create a GitHub release. The secrets are not visible by anyone, not even the person who created it. |
Thank you @HyperBrain and @miguel-a-calles-mba for keeping traction on this repo, it's very handy and still quite active! I'm eagerly awaiting PR #570 as I'm sure there are several others as well. |
@revgum np. I'm looking forward to other PRs too. =) |
@miguel Calles <miguelacallesmba@gmail.com> I will create a npm token and
let you know.
…On Wed, Apr 22, 2020 at 3:39 PM Miguel A. Calles MBA < ***@***.***> wrote:
@revgum <https://github.com/revgum> np.
I'm looking forward to other PRs too. =)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#581 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKEZXWQCVYO7GRBLLT3VL3RN3XSNANCNFSM4MMWXCSQ>
.
|
Thanks @HyperBrain ! |
@HyperBrain @jamesmbourne @rdsedmundo Reference the internal team discussion about the updated npm token secret. |
What did you implement:
Closes #XXXXX
Adding a GitHub Action to automatically publish to npm.
How did you implement it:
Added a GitHub Action YAML workflow.
How can we verify it:
Define the
NPM_TOKEN
secret in the settings. Update the package version, create a release, and see the action work. https://github.com/serverless-heaven/serverless-webpack/actionsTodos:
Is this ready for review?: YES
Is it a breaking change?: NO