Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Node versions in CI #587

Merged
merged 1 commit into from
May 15, 2020
Merged

Updated Node versions in CI #587

merged 1 commit into from
May 15, 2020

Conversation

miguel-a-calles-mba
Copy link
Member

@miguel-a-calles-mba miguel-a-calles-mba commented May 14, 2020

What did you implement:

Updated minimum node version in CI based on a recommendation in #570.

How did you implement it:

Updated the Travis and AppVeyor configurations.

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@miguel-a-calles-mba miguel-a-calles-mba requested review from a team May 14, 2020 23:51
@miguel-a-calles-mba miguel-a-calles-mba changed the title Updated Node version in CI Updated Node versions in CI May 14, 2020
@miguel-a-calles-mba miguel-a-calles-mba added this to the 5.3.3 milestone May 14, 2020
Copy link
Contributor

@jamesmbourne jamesmbourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think 10 and 12 is a sensible set of versions to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants