Update all examples #626
Merged
Update all examples #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So they are up to date with deps and they are all working (for sure: I've tested them one by one) Upgrade `"serverless-webpack": "file:../..",` to `"serverless-webpack": "^5.3",` because each test resulted in `Error: Cannot find module 'webpack'` ... (only with NPM not with Yarn) - remove outdated `babel` example because it use webpack 3 and it's superseded by `babel-webpack-4` - remove `serverless-offline` example as other one already use serverless-offline - update all examples to latest deps version
Avoid double build when PR is created on upstream (a build for PR and one for push). Only run coverage one build (and send coverage only once instead of twice). Also don't run coverage on Appveyor as we don't use it.
| # avoid double Travis build when the PR is created on upstream | ||
| if: | | ||
| type = pull_request OR \ | ||
| branch = master |
There was a problem hiding this comment.
Shouldn't we run builds on master to make sure it build properly? Some repositories treat master as unstable, but not sure whether we are doing that for this repo.
| @@ -6,7 +6,7 @@ plugins: | |||
|
|
|||
| provider: | |||
| name: aws | |||
| runtime: nodejs6.10 | |||
| runtime: nodejs12.x | |||
miguel-a-calles-mba
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
I updated all examples to latest deps & version.
They should all run properly and be up to date.
I've removed some of them because there weren't accurate as of today.
I've also updated the Travis build:
Note: I targeted master so dependabot PR will be closed automatically after merging that PR.
Note 2: lot of diff stuff but mostly due to lock files being updated.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO