Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support noFrozenLockfile options #687

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

tgroutars
Copy link
Contributor

What did you implement:

We have a monorepo with several serverless packages. Given the way we do CI and the way lerna deals with lockfiles, we actually don't need and don't have an up to date yarn.lock, but for our usecase it doesn't really matter.

This adds the option noFrozenLockfile to packagerOptions, allowing to run yarn install without the --no-frozen-lockfile option. This is as suggested in this comment #369 (comment)

I also fixed the documentation for ignoreScripts in the README, which mentioned a default value of true when it is in fact false

How did you implement it:

Added the option in the install function in yarn.js

How can we verify it:

I added tests to make sure the option was omitted when using noFrozenLockfile

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@tgroutars
Copy link
Contributor Author

@j0k3r

@j0k3r
Copy link
Member

j0k3r commented Feb 1, 2021

Following #655 & #686

@j0k3r j0k3r added this to the 5.4.0 milestone Feb 1, 2021
@j0k3r j0k3r merged commit c43bbc2 into serverless-heaven:master Feb 1, 2021
@j0k3r
Copy link
Member

j0k3r commented Feb 1, 2021

Thanks @tgroutars!

@tgroutars
Copy link
Contributor Author

No, thank you 🙏
Do you already know in which release this will be included?

@j0k3r
Copy link
Member

j0k3r commented Feb 1, 2021

I added it to the next release the 5.4.0.
There are still some PRs we would like to push in that release, but it's coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants