Add ability to specify the node_modules
relative dir
#689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
serverless-webpack uses
node_modules
to find out allpeerDependencies
but the assumption is thatnode_modules
is in the same directory as package.json. But this is not always true specially for monorepo case where node_modules are usually in one parent directory.This PR is to remove this assumption by adding one customer configuration
nodeModulesRelativeDir
. By default it follows current behaviour.It can addresses issue #431
How did you implement it:
How can we verify it:
Testing cases has been updated to cover with/without the new configuration.
README has been updated.
Testing shows below error message is gone and peerDependencies can be packed properly
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO