Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the zip method used #735

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Display the zip method used #735

merged 3 commits into from
Mar 18, 2021

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Mar 18, 2021

Since 5.4.0 we are using bestzip which can improve performance by using native zip method if available instead of the node one.
But we don't know which method is used during the build, so improving a small log to know that information.

Serverless: Zip service (using native zip method): /project/.webpack/service [11882 ms]

Also:

  • run npm audit fix to fix some vulnerabilities.
  • improve / cleanup return data from mocks

Since 5.4.0 we are using `bestzip` which can improve performance by using native `zip` method if available instead of the node one.
But we don't know which method is used during the build, so improving a small log to know that information.

```
Serverless: Zip service (using native zip method): /project/.webpack/service [11882 ms]
```

Also:
- run `npm audit fix` to fix some vulnerabilities.
- improve / cleanup return data from mocks
@j0k3r j0k3r added this to the 5.4.1 milestone Mar 18, 2021
@j0k3r j0k3r requested a review from a team March 18, 2021 18:17
Copy link
Member

@miguel-a-calles-mba miguel-a-calles-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the coverage dropped. I don't see any reduced coverage in the changes.

@j0k3r
Copy link
Member Author

j0k3r commented Mar 18, 2021

I think the drop is caused by the ternary condition because the hasNativeZip mock only returns false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants