fix: Correctly handle packaging for function during deploy -f
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffxsam
approved these changes
Apr 23, 2021
j0k3r
approved these changes
Apr 26, 2021
j0k3r
force-pushed
the
fix-behavior-for-deploy-function
branch
from
5bb4011 to
d63b6cd
Compare
|
Looks like coveralls has issue at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Correct behavior of
copyExistingArtifactswhen it's invoked as a part ofdeploy functioncommand.Closes: #737
How did you implement it:
I used a similar approach to one taken in a few different places when
functionis available inoptionsHow can we verify it:
Setup a project that has at least two functions and
package.individually: true. Deploy the stack and then try to deploy a single function withdeploy functioncommand. Previously it was failing when it tried to copy an artifact for other functions that the one specified withdeploy functioncommand.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO