Skip container function with uri defined
#877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
force-pushed
the
fix/skip-function-image-uri
branch
from
4f0f8ff
to
3075e24
Compare
miguel-a-calles-mba
requested changes
Aug 25, 2021
It looks like a container function defined with a `uri` shouldn't be handled by the plugin because the image won't be handled by Serverless itself. So we just skip the function in that case.
j0k3r
force-pushed
the
fix/skip-function-image-uri
branch
from
3075e24
to
c49d8ac
Compare
|
Sorry to reopen a finished discussion, but I guess this same fix could be applied when using simple strings on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a container function defined with a
urishouldn't be handled by the plugin because the image won't be handled by Serverless itself.So we just skip the function in that case.
Fix #825