Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way to detect external module from Webpack #953

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Sep 6, 2021

Fix #950 (the bug was introduced by Webpack 5.52.0)
Superseded #951

Also prepare release 5.5.4 to quickly release the bug fix.

@Phrensoua
Copy link

Wow rapide comme fix! Merci! - Fast! Thanks!

@j0k3r j0k3r requested a review from a team September 7, 2021 07:52
@Enase
Copy link

Enase commented Sep 7, 2021

Any chance to merge and release?

@j0k3r
Copy link
Member Author

j0k3r commented Sep 7, 2021

@Enase I can't force the merge, someone from the @serverless-heaven/serverless-webpack-team must approve it first.

Copy link
Member

@miguel-a-calles-mba miguel-a-calles-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@j0k3r j0k3r merged commit a962787 into master Sep 8, 2021
@j0k3r j0k3r deleted the fix/webpack-external-module branch September 8, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot read property '1' of null (not #193)
6 participants