Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make configSchemaHandler optional #12

Merged

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Sep 24, 2020

This change is required to make the plugin work with older versions of Serverless Framework, before the this.serverless.configSchemaHandler was introduced.

The error that you would get is:

  TypeError: Cannot read property 'defineCustomProperties' of undefined

I have tested this with v1.70 and v2.2.0`

Some other users have been experiencing this issue: e8ecb9f#commitcomment-41741520

@horike37
Copy link
Contributor

@andreafalzetti
LGTM. Thanks 😊 🙏

@horike37 horike37 merged commit 5861b75 into serverless-operations:master Sep 24, 2020
@horike37
Copy link
Contributor

This has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants