Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-593] Change selectpattern from int to string #594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Issue-593] Change selectpattern from int to string #594

wants to merge 1 commit into from

Conversation

louis0802
Copy link

@louis0802 louis0802 commented Oct 29, 2023 •
edited
Loading

Fixing for the issue #593

@louis0802
Copy link
Author

Hii @horike37 @lopburny,

Could we please have a look at this PR?

Thanks

@horike37
Copy link
Collaborator

@louis0802
Thank you for this PR. No one seems to face this issue. I'm concerned that this would introduce any side effects.
Could you check if it breaks the backward compatibility?

@louis0802
Copy link
Author

@louis0802 Thank you for this PR. No one seems to face this issue. I'm concerned that this would introduce any side effects. Could you check if it breaks the backward compatibility?

@horike37
May I have your help to check if it breaks the backward compatibility?
Is there any script or command I could run to verify it?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis0802 @horike37