-
Notifications
You must be signed in to change notification settings - Fork 216
feat: support JSONata query language #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I also updated the typescripts types: DefinitelyTyped/DefinitelyTyped#71344 |
@horike37 I tested this PR in my own project and it works. Please let me know what else is to do to get this merged :-) |
Woah thanks ! when will this new version will be live in npm ? |
Hey @olivierto not sure when @horike37 will release a new version. In the meantime, if you want to try it out you can install a preview version from this PR: That's how I tested it and use it currently. |
@zirkelc This is just partially working, right? I've just migrated a simple step function that does a ddb call and it's failing because for the permissions [getDynamoDBPermissions] it's not checking for |
@ebisbe yes it's not working for all resources except the nested stepFunctions. |
Hey, yes that might be true. I will into this! |
Hey @ebisbe and @olivierto I updated the A new preview release was created, see this comment: zirkelc#1 (comment) Since it's the same identifier, you might need to delete the dependency to force a re-install. Please give it a try and let me know if it works. Regarding the remaining AWS service: there are quite a lot of changes required to support If the latest changes for DDB work, I will submit a new PR to this repo so that other people can help support more services (if needed). |
Sorry @zirkelc but I'm using a fork where I added multiple other services that I needed credentials. I think I had a PR but eventually I close it because I saw it went nowhere. I think the main issue is still the maintainer which is not doing much and does not want to step down... |
@olivierto you can copy the updated tests from this commit: zirkelc@1900d04#diff-ac572495ab49814342a6cce41eb2e330796c89f16e3dcbcc1d0c7b6cfbaa7122 They only update DDB tests, but I think it's a good template on adding more tests for future services |
AWS recently introduced support for JSONata expressions as an alternative to JSONPath:
https://aws.amazon.com/blogs/compute/simplifying-developer-experience-with-variables-and-jsonata-in-aws-step-functions/
https://docs.aws.amazon.com/step-functions/latest/dg/transforming-data.html
This PR adds support for new fields to use JSONata expressions.