Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

feat: Add options to base plugin class #198

Merged
merged 2 commits into from
Jul 12, 2019
Merged

feat: Add options to base plugin class #198

merged 2 commits into from
Jul 12, 2019
+51 −27

Conversation

tbarlow12
Copy link
Contributor

Allows base plugin to access options and adds helper function getOption for all plugins to use

@coveralls
Copy link

Coverage Status

Coverage increased (+7.8%) to 84.169% when pulling 11d4b2e on tabarlow/base-plugin-options into 4208625 on dev.

wbreza
wbreza approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbarlow12 tbarlow12 merged commit d8cca60 into dev Jul 12, 2019
@tbarlow12 tbarlow12 deleted the tabarlow/base-plugin-options branch July 12, 2019 18:21
PIC123
PIC123 approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tbarlow12 added a commit that referenced this pull request Sep 13, 2019
@tbarlow12
feat: Add options to base plugin class (#198)
71bbd5d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ahemavathy ahemavathy ahemavathy approved these changes

@PIC123 PIC123 PIC123 approved these changes

@wbreza wbreza wbreza approved these changes

@mydiemho mydiemho mydiemho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tbarlow12 @coveralls @mydiemho @wbreza @PIC123 @ahemavathy