This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Removed service name from storage account name generator #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
suggested changes
Aug 8, 2019
tbarlow12
approved these changes
Aug 8, 2019
wbreza
force-pushed
the
wabrez/storage-name-refactor
branch
from
c8c6968 to
0b9b737
Compare
mydiemho
approved these changes
Aug 8, 2019
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
When the storage account name is generated it includes a hash of the sls service name. By default if you deploy multiple services/apps into the same resource group this causes multiple storage accounts to be created vs. reusing the same one. By removing the service name from the storage account generation logic it simplifies the case to reuse the same account. This value can still be overridden by specifying your own name in the sls yaml configuration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the storage account name is generated it includes a hash of the sls service name. By default if you deploy multiple services/apps into the same resource group this causes multiple storage accounts to be created vs. reusing the same one. By removing the service name from the storage account generation logic it simplifies the case to reuse the same account. This value can still be overridden by specifying your own name in the sls yaml configuration.