Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Register missing dependency #237

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Aug 9, 2019

src/test/mockFactory.js directly relies on @azure/ms-rest-js while it's not listed in package.json deps, which implies a risk of package not being properly installed in some scenarios.

@medikoo medikoo force-pushed the medikoo/register-missing-dependency branch from b769d54 to bd9f363 Compare August 9, 2019 12:38
@coveralls
Copy link

coveralls commented Aug 9, 2019

Coverage Status

Coverage remained the same at 83.74% when pulling 08e382a on medikoo:medikoo/register-missing-dependency into 962c619 on serverless:dev.

@tbarlow12
Copy link
Contributor

Looks great. If you can add the fix: prefix to the commit message before squash/merging, we'd appreciate it :)

@tbarlow12 tbarlow12 self-requested a review August 9, 2019 14:33
@medikoo medikoo force-pushed the medikoo/register-missing-dependency branch from bd9f363 to 08e382a Compare August 9, 2019 14:50
@medikoo
Copy link
Contributor Author

medikoo commented Aug 9, 2019

@tbarlow12 ok I've rebased it. Do you have any doc on CC rules (types to use etc.) you've settled on? (e.g. in one of the Serverless projects we use: https://docs.google.com/document/d/1hKUs3qt_aVp_PBI1UqvfaIqKma3jAJimEoGCRGGbOqs/ )

@mydiemho
Copy link
Contributor

@tbarlow12 ok I've rebased it. Do you have any doc on CC rules (types to use etc.) you've settled on? (e.g. in one of the Serverless projects we use: https://docs.google.com/document/d/1hKUs3qt_aVp_PBI1UqvfaIqKma3jAJimEoGCRGGbOqs/ )

@medikoo that's good idea, will add a task to add a CONTRIBUTE.md

@medikoo medikoo merged commit 1361dc9 into serverless:dev Aug 13, 2019
@medikoo medikoo deleted the medikoo/register-missing-dependency branch August 13, 2019 19:06
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants