This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Clean up downloaded artifact after rollback #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarlow12
force-pushed
the
tabarlow/clean-up-rollback
branch
from
713b7fc to
8fff46f
Compare
wbreza
reviewed
Aug 30, 2019
| @@ -98,6 +99,9 @@ export class RollbackService extends BaseService { | |||
| const functionAppService = new FunctionAppService(this.serverless, this.options); | |||
| const functionApp = await functionAppService.get(); | |||
| await functionAppService.uploadZippedArfifactToFunctionApp(functionApp, artifactPath); | |||
| if (fs.existsSync(artifactPath)) { | |||
There was a problem hiding this comment.
Aren't we already cleaning up this folder before deployment? Seems like we should maybe keep this around post deployment so developers can open up the zip more easily to inspect its contents??
There was a problem hiding this comment.
Nevermind - this is after a rollback - not deployment.
There was a problem hiding this comment.
still think it's good to keep around even for rollback. In case a rollback does not behave as expected, user can verify the deployed content
wbreza
approved these changes
Aug 30, 2019
| @@ -98,6 +99,9 @@ export class RollbackService extends BaseService { | |||
| const functionAppService = new FunctionAppService(this.serverless, this.options); | |||
| const functionApp = await functionAppService.get(); | |||
| await functionAppService.uploadZippedArfifactToFunctionApp(functionApp, artifactPath); | |||
| if (fs.existsSync(artifactPath)) { | |||
There was a problem hiding this comment.
Nevermind - this is after a rollback - not deployment.
mydiemho
approved these changes
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the downloaded artifact from
.serverlessafter deployed to serviceResolves #287