This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
fix: Updates default http output binding #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIC123
approved these changes
Sep 5, 2019
| if (bindingUserSettings[constants.webHookType]) { | ||
| binding[constants.name] = "res"; | ||
| } | ||
| binding[constants.name] = "res"; |
There was a problem hiding this comment.
Do we always want it to be res, or just default to it and still have the option of choosing the $return?
There was a problem hiding this comment.
I need the option of choosing $return instead of res.
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
This updates the default value for the name of the HTTP output binding from $return to $res to work around an issue that existing within the Azure core tools http runtime.. A bug exists in the Azure core tools http runtime that evaluates $return binding incorrectly which causes serialization issues when returning arrays within an HTTP response. Azure/azure-functions-nodejs-worker#228
|
@jon-lewis Even though the default has changed to You can modify your handler definition to include the output binding. When you handler specifies its own output binding then the default is ignored. Hope this helps. |
|
Perfect. I did test this out and the following settings worked for me. - http: true
x-azure-settings:
direction: out
name: $return |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the default value for the name of the HTTP output binding from
$returnto$resto work around an issue that existing within the Azure core tools http runtime..A bug exists in the Azure core tools http runtime that evaluates
$returnbinding incorrectly which causes serialization issues when returning arrays within an HTTP response.Azure/azure-functions-nodejs-worker#228