This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Default operation names no longer cause collisions #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #332 +/- ##
=========================================
+ Coverage 93.9% 94.67% +0.76%
=========================================
Files 47 47
Lines 1724 1727 +3
Branches 240 242 +2
=========================================
+ Hits 1619 1635 +16
+ Misses 105 92 -13
Continue to review full report at Codecov.
|
tbarlow12
approved these changes
Sep 12, 2019
mydiemho
approved these changes
Sep 12, 2019
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
APIM uses the operation name as the key when upserting operations into an API. By default we were using the function name as the operation name. During default configuration inference with multiple HTTP methods this caused a collision resulting in the last operation in always one. This fix generates a unique operation name taking into account the function name + the HTTP method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIM uses the operation name as the
keywhen upserting operations into an API. By default we were using the function name as the operation name. During default configuration inference with multiple HTTP methods this caused a collision resulting in the last operation in always one.This fix generates a unique operation name taking into account the function name + the HTTP method.