Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

adding validate github action to pull requests raised to the master branch #646

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

gligorkot
Copy link
Contributor

@gligorkot gligorkot commented Feb 28, 2023

What did you implement:

Addresses a part of #645

How did you implement it:

Added a validate Github action to lint and run unit tests + report coverage

How can we verify it:

It should run on Github when a PR is raised to the master branch

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • [ x Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@gligorkot gligorkot marked this pull request as ready for review February 28, 2023 20:25
@gligorkot
Copy link
Contributor Author

@medikoo this adds the validate.yml asked for in #645 - trying to get us closer to a release. Can you please have a look if this is what you expected?

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @gligorkot !

@medikoo medikoo merged commit 0610749 into serverless:master Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants