Custom Tagging and Policy enhancements #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now tags are compulsory for S3 client.
Tagging should be treated as optional.
This is required for instance to prevent public access to internal URLs through using Conditions in the policy.
|
Any chance we can merge this PR?? we would love to get this custom policy fix. cheers! |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added options for tagging and ability to define a custom bucket policy. We needed tagging automated because our DevOps team demanded it. We also needed to be able to configure inline bucket policy, primarily to prevent access to S3 from public domain. We thought these are useful enhancements others may enjoy having.