Allow a developer to remove the 'prod' stage text from bucket name. #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a stage name for test, dev, UAT, etc is great, but when you host a project using a CNAME domain for a nice project URL, the bucket name must match that domain name exactly.
Allowing the user to optionally specify a regex string removal of the (e.g.) prod stage name from the bucket name allows the developer to push the prod stage so the bucket name matches the client project's domain name, while still allowing dev, test, uat, etc. s3 endpoints.
Example
Now the user can go to dev at: http://dev.augrel.cartesive.com.s3-website-us-east-1.amazonaws.com
But also prod which EXACTLY matches the domain with CNAME forwarding:
http://augrel.cartesive.com