-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate js for other plugins #1
Comments
Could you describe your use case with a bit more details pls? |
Currently your plugin only generates the JavaScript before deployment. This means that all other serverless plugins are unable to work if they don't do a deployment. |
So you'd like to have a separate command to build from typescript to javascript? |
I think so. Or a way to configure it to trigger on a much earlier hook.
…On 23/04/2017 10:36 pm, "Johannes Schickling" ***@***.***> wrote:
So you'd like to have a separate command to build from typescript to
javascript?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAq3huFqutb7iCJUehpV-a6o5Wc0oJ4dks5ryymdgaJpZM4NDgm3>
.
|
A separate command is certainly doable. However, combining this plugin with other plugins could be problematic with the current plugin infrastructure provided by Serverless. Maybe @pmuens can provide some feedback on when this might change? |
Hey @silver2k the TypeScript plugin could expose own lifecycle events which can then be used to hook into via your own custom plugin. Here you can e.g. see the lifecycle events of the main Serverless package plugin (https://github.com/serverless/serverless/blob/e82e6265e3f9bcd62ac907f576b284f35c7863f4/lib/plugins/package/package.js#L26-L34) and here's an example how to hook into the The only thing to note is that you'll then have a dependency to the TypeScript plugin. So you need to make sure that both plugins are installed / usable. |
having a custom lifecycle would also make it easier to test i think |
@kandros would you be up for creating a PR for this? |
Is it possible to generate the JavaScript into the .build folder for other plugins to use? I.e. The mocha unit testing plugin and the offline plugin?
The text was updated successfully, but these errors were encountered: