Skip to content

Peer dependency not installed #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PaulAnnekov opened this issue Jun 9, 2019 · 1 comment
Closed

Peer dependency not installed #151

PaulAnnekov opened this issue Jun 9, 2019 · 1 comment
Labels

Comments

@PaulAnnekov
Copy link

PaulAnnekov commented Jun 9, 2019

git clone https://github.com/prisma/serverless-plugin-typescript.git
cd serverless-plugin-typescript/example
npm install

Gives npm WARN serverless-plugin-typescript@1.1.7 requires a peer of typescript@>=2.2.2 but none is installed. You must install peer dependencies yourself. warning.

npx serverless deploy -v throws Serverless plugin "serverless-plugin-typescript" initialization errored: Cannot find module 'typescript'

My npm version: 6.9.0.

Looks like npm ignores

"devDependencies": {
    "typescript": "^3.4.1"

installation when the same package in peerDependency exists.

We should update example and README to force user to specify typescript dependency in his package or remove peer dependency.

@divyenduz
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants