-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
excludeDevDependencies and symlinkOrCopy does not work well together #154
Comments
A fix has been merged for this issue in v1.1.8, I'll close this one for now. If it persists please open up a new one 😃 |
I believe this was this merge that broke us. Our node_modules is symlinked into our project directory. The use case is we have multiple sub-projects which share one set of dependencies. Rather than installing the same dependencies into 10 places, we use symlinks to tie node_modules into the sub-projects. Directly copying the node_modules breaks the symlink and our build fails, whereas <1.1.8 symlinks worked perfectly. |
Using this plugin together with serverless framework made my package HUUUGE because it included all of the devDependencies etc.
While researching I found this issue serverless/serverless#5396 and after more debugging I found the issue (on my system) serverless/serverless#5396 (comment)
Changing this function https://github.com/prisma/serverless-plugin-typescript/blob/master/src/index.ts#L227 to always do a copy and not use Symlinks excludes the devDependencies correctly.
The text was updated successfully, but these errors were encountered: