Skip to content

plugin compiles functions that do not use node runtime #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vectorjohn opened this issue Feb 3, 2020 · 4 comments
Closed

plugin compiles functions that do not use node runtime #198

vectorjohn opened this issue Feb 3, 2020 · 4 comments

Comments

@vectorjohn
Copy link

If I have a project that uses multiple runtimes (configured individually per function), using this plugin will treat them all as TypeScript and attempt to compile them. This blocks using the plugin in a mixed runtime environment.

@vectorjohn
Copy link
Author

#197 is my attempt at fixing this. It works when I use it for my case but I may have missed some corner cases.

NoxHarmonium pushed a commit to agiledigital/serverless-plugin-typescript that referenced this issue Feb 9, 2020
- Merge in the changes that vectorjohn made in a parallel PR (filtering
functions at the plugin level)
- Use lodash's pickBy to simplify some logic
- Fix an issue with mixed export syntax (export vs module.exports)
- Removed redundant tests

Fixes serverless#198
NoxHarmonium pushed a commit to agiledigital/serverless-plugin-typescript that referenced this issue Feb 9, 2020
- Merge in the changes that vectorjohn made in a parallel PR (filtering
functions at the plugin level)
- Use lodash's pickBy to simplify some logic
- Fix an issue with mixed export syntax (export vs module.exports)
- Removed redundant tests

Fixes serverless#198
NoxHarmonium pushed a commit to agiledigital/serverless-plugin-typescript that referenced this issue Feb 9, 2020
- Merge in the changes that vectorjohn made in a parallel PR (filtering
functions at the plugin level)
- Use lodash's pickBy to simplify some logic
- Fix an issue with mixed export syntax (export vs module.exports)
- Removed redundant tests

Fixes serverless#198
@wahlforss
Copy link

I need this also!

@vectorjohn
Copy link
Author

This is fixed in master (but not in any release yet!).

@avivshafir
Copy link

avivshafir commented Nov 6, 2022

why is this closed? I'm getting this error when combining node (typescript) and python runtimes
running the latest version 2.1.4

I'm getting the following error

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

I think when specifying packaging individually option we reach this line
https://github.com/serverless/serverless-plugin-typescript/blob/master/src/index.ts#L281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants