Skip to content

Missing file in package after migration from package.include to package.patterns #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinduris opened this issue Apr 28, 2021 · 5 comments · Fixed by #243
Closed

Comments

@martinduris
Copy link

Hi,

Serverless deprecated 'package.include' and new 'package.patterns' does not work with 'typescript-plugin-typescript'

Steps to reproduce

  1. not working
  • npm i
  • sls package
  • when i open ZIP file '.serverless/serverless-patterns-include.zip' i cannot find file 'openapi-doc.yaml' inside 'src' folder
  1. working
  • Open 'serverless.yaml' and uncomment 'package.include'
  • repeat same steps, you should be able to find file included

Thans a lot for help!

@CrshOverride
Copy link

This one bit me yesterday as well. Currently the Serverless CLI warns about future deprecation when using include/exclude as part of package.

@tim-oe
Copy link

tim-oe commented May 30, 2021

have hit same issue changing include to patterns fails
also have the following plugins

  • serverless-localstack
  • serverless-plugin-typescript
  • serverless-plugin-include-dependencies
  • serverless-plugin-common-excludes

@demsey2
Copy link

demsey2 commented Jun 11, 2021

any update on this issue?

@medikoo
Copy link
Contributor

medikoo commented Jul 16, 2021

Will be fixed with #243

@nake89
Copy link

nake89 commented Jul 25, 2021

@JackCuthbert could you have a look at this. Thank you in advance :)
medikoo has made a PR that would fix this: #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants