Skip to content

[Feature Request] OpenWhisk support would be awesome #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
develpr opened this issue Apr 2, 2018 · 2 comments
Open

[Feature Request] OpenWhisk support would be awesome #93

develpr opened this issue Apr 2, 2018 · 2 comments

Comments

@develpr
Copy link

develpr commented Apr 2, 2018

I've seen that there is now support for google as a provider with one of the somewhat recent changes, but it would be awesome to also include support for OpenWhisk. I'm going to look to see if I can figure out what would be involved in this, but if anybody has any great thoughts / feelings about this I would be very appreciative!

@develpr
Copy link
Author

develpr commented Apr 2, 2018

I spent a bit of time looking at this and it seems like things almost "just work", but there is an issue (not sure if it's an "issue" or just an incompatibility!) with how OpenWhisk validates actions that causes issues when used with the typescript plugin. You can see the tiny changes (just temporary for now!) I made in a fork of the openwhisk repo to see what I'm talking about:

develpr/serverless-openwhisk@a0c9617

@develpr
Copy link
Author

develpr commented Apr 9, 2018

I ended up adding a PR after spending some time looking at how this plugin works with the serverless-openwhisk plugin. The PR (linked here) is pretty small and simple and basically just filters out "sequence" functions which in OpenWhisk may not actually contain a handler.

There is also a problem on the OpenWhisk side of things that I also have a PR out there for, which is that the openwhisk plugin will check for a particular handler with a hardcoded ".js" extension in the originally defined path. So, if you have myFunction.ts for example, that is being transpiled by the typescript plugin then the openwhisk plugin will throw an exception because it expects myFunction.js to exist. Anyway, I have a somewhat band-aid (?) fix of a PR out there in the OpenWhisk plugin to solve this for now.

Given a bit more time I'll try to test the full scope of what OpenWhisk + Serverless can do with the tyepscript implementation and hopefully write some tests also, for now I'm not sure that my small fixes will solve every incompatibility but at least it's something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant