-
Notifications
You must be signed in to change notification settings - Fork 230
Copy node_modules folder when symlink fails #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import * as path from 'path' | ||
import * as fs from 'fs-p' | ||
|
||
export class DeployBuilder { | ||
build(buildFolder: string) { | ||
const buildPath = path.resolve(buildFolder) | ||
|
||
if (this.isNodeModulesAbsent(buildPath)) { | ||
this.createNodeModulesFolder(buildPath) | ||
} | ||
} | ||
|
||
private isNodeModulesAbsent(buildPath: string): boolean { | ||
return !fs.existsSync(path.join(buildPath, 'node_modules')) | ||
} | ||
|
||
private createNodeModulesFolder(buildPath: string) { | ||
try { | ||
fs.symlinkSync(path.resolve('node_modules'), path.join(buildPath, 'node_modules')) | ||
} catch (error) { | ||
this.copyIfMissingSymlinkPermission(buildPath, error) | ||
} | ||
} | ||
|
||
private copyIfMissingSymlinkPermission(buildPath: string, error: SymlinkException) { | ||
if (this.isMissingSymlinkPermission(error)) { | ||
fs.copySync(path.resolve('node_modules'), path.join(buildPath, 'node_modules')) | ||
} else { | ||
throw error | ||
} | ||
} | ||
|
||
private isMissingSymlinkPermission(error: SymlinkException): boolean { | ||
// Generally happens when no admin rights with UAC enabled on Windows. | ||
return error.code === 'EPERM' && error.errno === -4048 | ||
} | ||
} | ||
|
||
export interface SymlinkException { | ||
code: string | ||
errno: number | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you pulled out this complexity to a separate file but I don't think that the name is intuitive and it doesn't need to be a class.
I'd suggest you export a function called
symlink
instead of a class and use all of the functions outside of the scope of a class.Does that make sense to you? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It does :)
The purpose of this class is to prepare the deployment. It just happens that I refactored a little piece of it. I intended to put all the deployment part on it.
What do you think? Should I complete the refactoring or keep it in the monolite way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's great that you're splitting it up into multiple functions, I just think they don't need to live inside a class.