feat: Add docker rootless feature flag and its implementation for sup…

…porting docke rootless environment
serverless · Feb 10, 2024 · aa3b05e · aa3b05e
1 parent 1b0faae
commit aa3b05e
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 12 deletions.
diff --git a/index.js b/index.js
@@ -50,6 +50,7 @@ class ServerlessPythonRequirements {
         dockerBuildCmdExtraArgs: [],
         dockerRunCmdExtraArgs: [],
         dockerExtraFiles: [],
+        dockerRootless: false,
         useStaticCache: true,
         useDownloadCache: true,
         cacheLocation: false,

diff --git a/lib/pip.js b/lib/pip.js
@@ -327,12 +327,17 @@ async function installRequirements(targetFolder, pluginInstance) {
         }
         // Install requirements with pip
         // Set the ownership of the current folder to user
-        pipCmds.push([
-          'chown',
-          '-R',
-          `${process.getuid()}:${process.getgid()}`,
-          '/var/task',
-        ]);
+        // If you use docker-rootless, you don't need to set the ownership
+        if (options.dockerRootless !== true) {
+          pipCmds.push([
+            'chown',
+            '-R',
+            `${process.getuid()}:${process.getgid()}`,
+            '/var/task',
+          ]);
+        } else {
+          pipCmds.push(['chown', '-R', '0:0', '/var/task']);
+        }
       } else {
         // Use same user so --cache-dir works
         dockerCmd.push('-u', await getDockerUid(bindPath, pluginInstance));
@@ -345,12 +350,16 @@ async function installRequirements(targetFolder, pluginInstance) {
       if (process.platform === 'linux') {
         if (options.useDownloadCache) {
           // Set the ownership of the download cache dir back to user
-          pipCmds.push([
-            'chown',
-            '-R',
-            `${process.getuid()}:${process.getgid()}`,
-            dockerDownloadCacheDir,
-          ]);
+          if (options.dockerRootless !== true) {
+            pipCmds.push([
+              'chown',
+              '-R',
+              `${process.getuid()}:${process.getgid()}`,
+              dockerDownloadCacheDir,
+            ]);
+          } else {
+            pipCmds.push(['chown', '-R', '0:0', dockerDownloadCacheDir]);
+          }
         }
       }