Fix --cache-dir with Docker #145
Conversation
Without supplying a user Docker defaulted to root That caused pip to refuse to use any specified --cache-dir because it's owned by the user Run Docker as the user so it has proper access to any -cache-dir
|
It depends on the virtual machine running Docker and I've never seen it not be 1000. The selected image should never affect this, because it's a property of the mounted files. I have added code to detect it. I'm using |
|
Cool, that makes sense. Do you think this technique would work on macOS too? |
|
I think it should. Regardless of the mapping the host OS has for file permissions, what's important is the how Docker, and therefore |
|
The failure seems unrelated. Some random failure to install |
|
Yup. Done. |
lib/pip.js
Outdated
| // const stripCmd = quote([ | ||
| // 'find', targetRequirementsFolder, | ||
| // '-name', '"*.so"', | ||
| // '-exec', 'strip', '{}', '\;', | ||
| // ]); | ||
| // pipCmd = ['/bin/bash', '-c', '"' + pipCmd + ' && ' + stripCmd + ' && ' + chownCmd + '"']; | ||
| } else if (process.platform === 'win32') { |
There was a problem hiding this comment.
Could you change this to an empty else (or add macOS/darwin)? and I'll have some one with a mac test it.
There was a problem hiding this comment.
Is Circle.CI configured to test on Mac OS X too?
There was a problem hiding this comment.
Nope, AFAIK circle doesn't offer free mac os builds.
There was a problem hiding this comment.
Would you be open to moving to Travis.CI? Mac builds are free there and I think they have a working Docker setup too.
| ]); | ||
| pipCmd = ['/bin/bash', '-c', '"' + pipCmd + ' && ' + chownCmd + '"']; | ||
| // Use same user so requirements folder is not root and so --cache-dir works | ||
| cmdOptions.push('-u', `${process.getuid()}`); |
There was a problem hiding this comment.
@cgrimal, AFAICT you added the chown stuff. Could you test this alternative?
There was a problem hiding this comment.
FWIW tests passed on Linux with all Docker tests enabled. There was no problem deleting the .serverless folder.
Without supplying a user Docker defaulted to
rootThat caused pip to refuse to use any specified
--cache-dirbecause it's owned by the userRun Docker as the user so it has proper access to any
--cache-dir