Fix corrupted zip archive in case of same module

[st4lk]

Problem

We have different functions with different runtime (not only python) defined in serverless.yml.
For python runtime, there are several functions defined in one file with same dependencies.
To be able to build a package, I have to specify the module param, since requirements for our python functions are not placed in a root folder of the project.

Project structure (simplified):

my-serverless-project
├── api
│   ├── users
│   │   ├── handlers.py
│   │   └── requirements.txt
│   └── generator
│       └── some-non-python-functions-here
└── serverless.yml

In api/users/handlers.py we have several functions:

def func1(event, context):
    # ...


def func2(event, context):
    # ...

serverless.yaml (some directives are omitted for simplicity):

package:
  individually: true


  functions:
    generator:
      runtime: non-python
      # ...
    func1:
      handler: handlers.func1
      module: api/users
      runtime: python3.6
      events:
        - http:
            path: one
            method: get
    func2:
      handler: handlers.func2
      module: api/users
      runtime: python3.6
      events:
        - http:
            path: two
            method: get

plugins:
  - serverless-python-requirements

custom:
  pythonRequirements:
    dockerizePip: true
    dockerImage: lambci/lambda:build-python3.6

As you can see, both func1 and func2 are declared in same python file, but these are different lambda functions. And they have same dependencies, i.e. same requirmemnts.txt file. We found such code structure useful.

When I try to create a package:

sls package

The resulting archive in .serverless/api/users.zip is corrupted. I suppose the reason is that serverless-python-requirements creates zip archives for different functions asynchronously. Since both functions have same module path - they have same artifact archive.
I can't unzip it and deploy is not working as well.

The archive is fine when I delete func2 from serverless.yml.

Solution

The easiest solution that comes to my mind is to include func name to the artifact zip archive. In that way it works well.

[st4lk]

• One more update (2nd commit): do not try to install requirements for non-python runtime.
  Otherwise, sls shows this error:

  ENOENT: no such file or directory, open 'requirements.txt'

[dschep]

Merged & linted into pr #180 since i think this ifxes some issues i was having in that pr.

[dschep]

Merged #180 which contained the changes from this PR too. I'd love it if you could test this change before I push to npm. Install with npm i UnitedIncome/serverless-python-requirements