-
Notifications
You must be signed in to change notification settings - Fork 293
Fix single function deployment #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single function deployment #490
Conversation
There is also this PR that also attempts to fix the same issue: #428. What that PR does is trying to guess the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, looks good!
hi, is this going to be merged? |
Is this still being worked on? |
@GCO-NZ Just waiting for it to be merged only. |
@jacksgt can you merge this or does @lephuongbg need to update the PR? Thanks |
@mirstan I don't have any permissions on this repo. |
This is pretty huge functionality for anybody working on projects with a lot of functions. My entire project takes upwards of 45 minutes to deploy, but a single function deployment only takes around 30s. We should really get merging this prioritized! I have been using this as a local patch for months now with no issues. If there's anything else I can do to speed up the merge please let me know! |
@bsamuel-ui @AndrewFarley @miketheman Can this be merged? |
Agreed on prioritizing this. |
@lephuongbg can you add a dummy commit to trigger CI? |
5e96143
to
10319b2
Compare
10319b2
to
41a49cc
Compare
@bsamuel-ui I've rebased this branch on master. |
@lephuongbg Can you try editing |
@bsamuel-ui Just did but what was supposed to happen? |
@lephuongbg All the CI ran... and we've got some tests failing. Can you look into those? |
Please refer to #550 |
This will fix serverless/serverless#6752 and #414