Skip to content

Fix single function deployment #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lephuongbg
Copy link
Contributor

This will fix serverless/serverless#6752 and #414

@lephuongbg
Copy link
Contributor Author

There is also this PR that also attempts to fix the same issue: #428.

What that PR does is trying to guess the artifactPath, which I feel a bit more fragile and also more code needed than this PR's approach.

Copy link
Contributor

@jacksgt jacksgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, looks good!

@mirstan
Copy link

mirstan commented Apr 23, 2020

hi, is this going to be merged?

@gavinconnellotten
Copy link

Is this still being worked on?

@lephuongbg
Copy link
Contributor Author

@GCO-NZ Just waiting for it to be merged only.

@mirstan
Copy link

mirstan commented Jun 16, 2020

@jacksgt can you merge this or does @lephuongbg need to update the PR? Thanks

@jacksgt
Copy link
Contributor

jacksgt commented Jun 18, 2020

@mirstan I don't have any permissions on this repo.

@jimpudar
Copy link

jimpudar commented Sep 9, 2020

This is pretty huge functionality for anybody working on projects with a lot of functions. My entire project takes upwards of 45 minutes to deploy, but a single function deployment only takes around 30s.

We should really get merging this prioritized!

I have been using this as a local patch for months now with no issues. If there's anything else I can do to speed up the merge please let me know!

@Aubtin
Copy link

Aubtin commented Sep 16, 2020

@bsamuel-ui @AndrewFarley @miketheman

Can this be merged?

@bsamuel-ui
Copy link
Contributor

Agreed on prioritizing this.

@bsamuel-ui
Copy link
Contributor

@lephuongbg can you add a dummy commit to trigger CI?

@lephuongbg lephuongbg force-pushed the fix-single-function-deployment branch from 5e96143 to 10319b2 Compare September 17, 2020 02:42
@lephuongbg lephuongbg force-pushed the fix-single-function-deployment branch from 10319b2 to 41a49cc Compare September 17, 2020 02:46
@lephuongbg
Copy link
Contributor Author

@bsamuel-ui I've rebased this branch on master.

@bsamuel-ui
Copy link
Contributor

@lephuongbg Can you try editing .github/workflows/test.yml to change on: [push] to on: [push, pull-request]?

@lephuongbg
Copy link
Contributor Author

@bsamuel-ui Just did but what was supposed to happen?

@bsamuel-ui
Copy link
Contributor

bsamuel-ui commented Sep 18, 2020

Just did but what was supposed to happen?

@lephuongbg All the CI ran... and we've got some tests failing. Can you look into those?

@bsamuel-ui
Copy link
Contributor

Please refer to #550

@bsamuel-ui bsamuel-ui merged commit b5cdf16 into serverless:master Oct 1, 2020
@lephuongbg lephuongbg deleted the fix-single-function-deployment branch October 19, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix PR that fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy single lambda function for version 1.52.1
7 participants