Handle all requirement flags properly and strip -e flags #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch, the plugin will respect all pip install short flags, not just -f and -i. https://pip.pypa.io/en/stable/reference/pip_install/#requirements-file-format
Previously, there were various with installing editable packages in different python / pip versions. serverless#240 This adds logic to strip out all '-e' editable flags from the requirements.txt file and issues a warning to the CLI. fixes serverless#240
jacksgt
force-pushed
the
pr-editable
branch
6 times, most recently
from
56cea06 to
0dee94c
Compare
Previously, requirements with the -e flag where completely ignored serverless#36 With the latest patch, the -e flag are stripped out, but the requirement itself is preserved. This patch adds a check to test this desired behavior.
|
@bsamuel-ui Hey, I rebased this PR onto master and updated all the tests as necessary (async test, prettier etc.). Have a great weekend! |
|
Nope, it's good to go! |
|
Great, thanks! |
Twista
pushed a commit
to Twista/serverless-python-requirements
that referenced
this pull request
Nov 19, 2020
Handle all requirement flags properly and strip -e flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
error: option --home not recognized#240I have also added an additional test patch that verifies this behavior.