Fix error git clone failed with error code 128 - Windows #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #550 |
jacksgt
reviewed
Sep 20, 2020
| @@ -212,6 +212,8 @@ function installRequirements(targetFolder, serverless, options) { | |||
| '-e', | |||
| 'SSH_AUTH_SOCK=/tmp/ssh_sock' | |||
| ); | |||
| chmod_cmd = ['chmod', '600', '/root/.ssh/id_rsa']; | |||
There was a problem hiding this comment.
Is it possible to only run this command for Windows environments?
If possible, we should try to avoid modifying the permissions of user's files (since the SSH private key is mounted from the user directly).
Also, please keep in mind that there may be other, non-RSA private keys.
|
Hey @joelrojas - it was a long time since this PR was proposed - I'm going to close it and if you'd still like to work on this one, please propose a new PR against latest main branch. Thanks 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker for Windows has some issues with the permissions when mounting files in containers.
docker/for-win#2042